RFR: 8048020 - Regression on java.util.logging.FileHandler
Alan.Bateman at oracle.com
Wed Jun 25 15:07:25 UTC 2014
On 24/06/2014 19:34, Daniel Fuchs wrote:
> Please find below a patch  for :
> 8048020 - Regression on java.util.logging.FileHandler
> This corresponds to the problem that was discussed on this list
> in the following email thread:
> "Zombie FileHandler locks can exhaust all available log file locks."
>  http://cr.openjdk.java.net/~dfuchs/webrev_8048020/webrev.00/
>  https://bugs.openjdk.java.net/browse/JDK-8048020
> This patch would be a good candidate for being backported on 8, since
> the issue was introduced in 8.
Catching OverlappingFileLockException is usually a sign of a mis-use.
Can you summarize how this comes about (given the locking on "locks").
The three Files.isXXX are expensive. This may be a case where you just
attempt to create the file with FileChannel.open. It probably should be
CREATE + WRITE + APPEND to avoid the case of another process or VM
removing the file at around the same time.
More information about the core-libs-dev