RFR: JDK-8035340 - (prefs) Check jdk/src/windows/native/java/util/WindowsPreference.c for JNI pending exceptions

Mark Sheppard mark.sheppard at oracle.com
Wed Mar 5 22:05:55 UTC 2014

thanks Alan  ... excellent spot (L124)


On 05/03/2014 21:33, Alan Bateman wrote:
> On 05/03/2014 19:53, Mark Sheppard wrote:
>> Hi
>>     Please oblige and review the following changes
>> http://cr.openjdk.java.net/~msheppar/8035340/webrev/
>> which address the issues raised in
>> https://bugs.openjdk.java.net/browse/JDK-8035340
>> This effort adds NULL checks and pending exception check after
>> JNI calls and adds NULL check to malloc calls in WindowsPreferences.c
>> This is a Windows change set.
> This mostly looks okay to me. One thing is the return path at L124 
> where I assume it should release valueNameStr. Could you also look at 
> the indentation of return at L121 as it initially looks like later 
> code is dead code. Otherwise looks okay.
> -Alan.

More information about the core-libs-dev mailing list