RFR (JAXP): 8035577: Xerces Update: impl/xpath/regex/RangeToken.java
huizhe.wang at oracle.com
Wed Mar 5 22:10:59 UTC 2014
On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote:
> On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
>> (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as well?
> I would agree given you are now calling Character.toLowerCase
Also, at line 463 and 464, it looks like 'uppers' meant to be 'lowers'
defined at 462.
>> (2) StringBuilder can be used to replace the StringBuffer in toString().
> Agree, but I think this could be considered optional for this putback...
Yes, feel free to replace StringBuffer with StringBuilder, Vector to
ArrayList and etc.
>> On 03/05/2014 12:18 PM, David Li wrote:
>>> This is an update from Xerces for file impl/xpath/regex/TokenRange.java. For details, please refer to: https://bugs.openjdk.java.net/browse/JDK-8035577.
>>> Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
>>> No new tests. There were none added in Xerces.
>>> Existing tests: JAXP SQE and unit tests passed.
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
More information about the core-libs-dev