RFR: (s) 8036095: RMI tests using testlibrary.RMID and testlibrary.JavaVM do not pass through vmoptions

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 6 08:29:15 UTC 2014

On 05/03/2014 22:05, Stuart Marks wrote:
> Hi all,
> Please review this fix to change RMI's test library to pass through 
> vmoptions and javaoptions to rmid and other JVM subprocesses.
> I've marked this as a "small" review because the changes of substance 
> are confined to the first four files in the webrev, and they're pretty 
> small. The remaining changes are to the individual security.policy 
> files of each test, which requires different permissions granted in 
> order to allow reading of the test.vm.opts and test.java.opts properties.
> Webrev:
>     http://cr.openjdk.java.net/~smarks/reviews/8036095/webrev.0/
I've looked through the changes and they look okay to me. I also grabbed 
the patch and ran the jdk_rmi tests with a few XX options specific to 
jtreg via -vmoption and it works.

Just on David's comment then I think it would be surprising to specify 
options to jtreg but have some but not all tests use it consistently. 
There have been a number of passes over the shell tests to make sure 
that VM options are passed through but there is still work required to 
check tests that use Runtime.exec or ProcessBuilder to start other VMs 
to see that they pass through the expected options. As to whether 
someone would run these tests with -Xcomp or other stress options then I 
don't know but if they do then it would be strange for some tests to use 
it and not others.


More information about the core-libs-dev mailing list