RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions

Mark Sheppard mark.sheppard at oracle.com
Wed Mar 12 17:47:56 UTC 2014

Hi Alan,
    so L61 should be

if ((bytes = (*env)->NewByteArray(env, i)) == NULL) {
     return NULL;


On 12/03/2014 17:24, Alan Bateman wrote:
> On 12/03/2014 17:18, Mark Sheppard wrote:
>> Hi
>>    an updated webrev as per suggested changes
>> http://cr.openjdk.java.net/~msheppar/8036603/webrev.01/
> This looks good. One other thing in this code (pre-dates your patch 
> but your patch makes it a bit more obvious) is that if NewByteArray 
> fails then we don't call FreeEnvironmentStringsA to free the environment.
> -Alan

More information about the core-libs-dev mailing list