RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError
yekaterina.kantserova at oracle.com
Tue Mar 25 14:31:09 UTC 2014
On 03/25/2014 02:53 PM, Alan Bateman wrote:
> On 25/03/2014 12:14, Staffan Larsen wrote:
>> I’ve looked at a random sample of these changes and they look ok.
>> Since some of the changes are in non-serviceability code I have also
>> added core-libs to the review thread.
>> I’m sure you know this, but for the record: please don’t push this
>> until jtreg with the fix has been promoted.
> Katja - the changes look okay but I wonder about tests that didn't
> previously have @build or @compile tags. Take TestJcmdDefaults as an
> example, it now has:
> @build jdk.testlibrary.*
> and I just wonder if it should be:
> @build TestJcmdDefaults jdk.testlibrary.*
> so that it compiles the test in addition to the test library. This
> could be a misunderstanding on my part of course, maybe the source
> file with @test is always compiled if it's a java test?
My assumption is the test itself is always compiled. If it's false, I'm
afraid we need to change a bunch of other tests.
Jon, could you please explain?
More information about the core-libs-dev