[9] RFR (XXS): 8035186: j2se_jdk/jdk/test/java/lang/invoke/lambda/LogGeneratedClassesTest.java - assertion error

Paul Sandoz paul.sandoz at oracle.com
Wed May 28 10:04:38 UTC 2014

On May 27, 2014, at 6:16 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> Good catch!
> One more iteration:
> http://cr.openjdk.java.net/~vlivanov/8035186/webrev.02/

Looks good.

Some minor points, no need for another review round either way:

- don't need the nested try blocks in isWriteableDirectory, just tack the finally block on the end of the last catch block.

- could add a println when there is no POSIX environment to indicate the test is not run and remove it when/if jtreg supports skipping.


More information about the core-libs-dev mailing list