RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image
Alan.Bateman at oracle.com
Thu Sep 11 12:39:26 UTC 2014
On 11/09/2014 12:20, Miroslav Kos wrote:
> please review following change:
> JBS: https://bugs.openjdk.java.net/browse/JDK-8054548
> webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/
> It is basically replacing obsolete code using core reflection by
> javax.tools API plus removing old unused code.
Thanks for doing this, it's good to get this cleaned up.
The changes looks reasonable but I wonder if they are complete. I ask
because I assumed that JavaCompilerHelper.getJarFile would be removed.
Also there appears to be a bit of skullduggery in both wsimport and
wsgen involving -Xbootclasspath/p where it might be assuming that the
JAXB or JAX-WS classes are being loaded from JAR files (I didn't did
into ParallelWorldClassLoader.toJarUrl so perhaps it can deal with other
In passing, I assume the comments in Invoker should use "ClassLoader" or
"class loader". Also the comment in createClassLoader mentions JAXB/WS
2.1 and not clear how this relates to the method description where it
talked about 2.2
In JavacompilerMessages then noJavaCompilerError() and
localizedNoJavaCompilerError() might be nicer names (in case you are
looking for something better).
More information about the core-libs-dev