RFR [8058099] (ch) Cleanup in FileChannel/FileDispatcher native implementation [win]

Ivan Gerasimov ivan.gerasimov at oracle.com
Wed Sep 17 08:08:37 UTC 2014


Is there any interest in this change?
It's mostly cleanup, so it is of low priority, but it would be good, if 
someone could review this.

Besides increased readability, this fix makes the code 24 lines shorter 
and eliminates a compiler warning! :-)

Sincerely yours,

On 10.09.2014 14:36, Ivan Gerasimov wrote:
> Hello!
> This is a proposal to slightly rework FileChannel/FileDispatcher 
> native implementation on Windows.
> If the newer API is used (which is already available on XP and 2003), 
> this will make code a bit clear and let us save a few redundant calls.
> Would you please help review the change?
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8058099
> WEBREV: http://cr.openjdk.java.net/~igerasim/8058099/0/webrev/
> Sincerely yours,
> Ivan

More information about the core-libs-dev mailing list