RFR: 8076090: jimage extract + recreate broken again

Mandy Chung mandy.chung at oracle.com
Wed Apr 8 18:37:50 UTC 2015

Forwarding to core-libs-dev for review (bcc jdk9-dev)

On 4/8/2015 11:02 AM, Jim Laskey (Oracle) wrote:
> The fix addresses problem with the jimage tool rebuilding meta data on windows systems (\ in path.)  Including new test to verify that jimage tool does successfully extract and recreate.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8076090
> Webrev: http://cr.openjdk.java.net/~jlaskey/8076090/webrev/index.html

Looks fine to me.

The test will need to check if $JAVA_HOME is an exploded image 
($JAVA_HOME/lib/modules not exists); if so, it should simply exit. 
Otherwise the test will fail.   Nit: line 24 is not unused.

FYI.  jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java could 
be used.


More information about the core-libs-dev mailing list