[9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

Roger Riggs Roger.Riggs at Oracle.com
Wed Apr 15 18:53:46 UTC 2015

Hi Brian,

Looks fine to me.

Thanks, Roger

On 4/15/2015 2:41 PM, Brian Burkhalter wrote:
> Updated and hopefully final patch here:
> http://cr.openjdk.java.net/~bpb/8075156/webrev.02/
> Test run in progress.
> Barring any objections I assume that changing CODE_POINT_U0000 from a String to an int does not require another Reviewer approval, so I will go ahead and push the fix after the yet to be refreshed CCC request is approved, if it is.
> Thanks,
> Brian
> On Apr 15, 2015, at 10:08 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>>> But I'm curious why CODE_POINT_U000 is defined as  String instead of char?
>>> The indexOf() operation is more efficient for single characters.
>> Probably because I had initially used contains(CharSequence) instead of indexOf(String) and when I changed the former to the latter I did not change the constant. I will modify this per your suggestion.

More information about the core-libs-dev mailing list