RFR 9: 8077350 Process API Updates Implementation Review (Due 4/23)
paul.sandoz at oracle.com
Tue Apr 21 12:29:54 UTC 2015
On Apr 20, 2015, at 8:42 PM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
> Hi Paul,
> On 4/20/2015 2:26 PM, Paul Sandoz wrote:
>> On Apr 20, 2015, at 7:33 PM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>>> Hi Paul,
>>> There are statements in Process about the specified behavior of Processes
>>> created by ProcessBuilder. That's why I included them in the @implSpec clause.
>>> If @implSpec is only for the specifics of the method itself then where
>>> should the behavior of ProcessBuilder created instances be specified?
>> I think the @implNote you have on Process.onExit about Processes from ProcessBuilder being more efficient is fine, but that @implNote also appears to mix stuff that is @implSpec for the method itself.
> I don't see anything in that @implNote that is spec; just informative.
Process.onExit triggering waitFor to be called asynchronously in another thread seems more spec-like to me (without defining what the executor of the CF is, but we can probably specify what it is not i.e. the CF should be executed on the f/j common pool). How could it be otherwise?
More information about the core-libs-dev