[9] RFR of 8078672: Print and allow setting by Java property seeds used to initialize Random instances in java.lang numerics tests

joe darcy joe.darcy at oracle.com
Tue Apr 28 00:32:33 UTC 2015

Hi Brian,

The patch looks pretty good. A few questions / comments:

The test ParseHexFloatingPoint.java didn't get the "(use -Dseed=X to set 
PRNG seed)" addition; was that intentional?

To save some space on the @summary line

     Numerical tests for hexadecimal inputs to parseDouble, parseFloat

could be replaced with

     Numerical tests for hexadecimal inputs to parse{Double, Float}

Could the java/math/RandomSeed class you added for java.math be used for 
this changeset instead of another another class with a large subset of 
the functionality?

Perhaps the random number handling should be moved up to somewhere under 
jdk/test/lib? That would more easily let other type who want to handling 
random numbers in a uniform way use the library (at the cost of slightly 
more complicated jtreg tagging).



On 4/27/2015 1:41 PM, Brian Burkhalter wrote:
> Note: This is a relabeling and extension of a patch originally addressed towards https://bugs.openjdk.java.net/browse/JDK-8078586 in this discussion thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/033037.html.
> With that preamble, please review the revised code at your convenience:
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8078672
> Patch:	http://cr.openjdk.java.net/~bpb/8078672/webrev.00/
> Summary: Add setting of Random seed via system property with fallback to a random seed from a separate Random instance and printing the seed actually used in the test.
> Thanks,
> Brian

More information about the core-libs-dev mailing list