Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api
huizhe.wang at oracle.com
Thu Aug 6 00:13:29 UTC 2015
This looks good to me.
On 8/5/2015 3:04 AM, Frank Yuan wrote:
> Hi Joe
> Thank you very much! Really good advice! I have adjusted as it, please
> re-check at:
> Btw, I only applied this practice on unit test, not for functional
> test because Tristan still has a functional suite pending, I would
> unify the functional part sometime after that suite is finished.
> Best Regards
> *From:*huizhe wang [mailto:huizhe.wang at oracle.com]
> *Sent:* Wednesday, August 05, 2015 2:26 AM
> *To:* Frank Yuan <frank.yuan at oracle.com>
> *Cc:* 'core-libs-dev' <core-libs-dev at openjdk.java.net>; 'Alan Bateman'
> <Alan.Bateman at oracle.com>; 'Jan Lahoda' <jan.lahoda at oracle.com>
> *Subject:* Re: Review request for JDK-8132660: Change jaxp unit test
> package name to be different with jaxp api
> Hi Frank,
> That looks fine. However, instead of appending an additional directory
> "utests", you could make the paths shorter by removing "javax/xml" and
> "org/w3c" or "org/xml". The short names are good enough to represent
> the API names, test/javax/xml/jaxp/unittest/parsers for example, is
> easily recognizable as a package that holds the tests for
> javax/xml/parsers. JAXP tests currently in the jdk test repositories
> are named using this approach.
> On 8/3/2015 11:51 PM, Frank Yuan wrote:
> Hi, Joe and all
> Would you like to have a review for bug
> This is already on our plan for a while, but I have to finish it
> now because these unit tests failed with latest Jigsaw build.
> However I made the changes based on 9-dev repo, I tested them with
> both Jigsaw build and 9-dev build. The JPRT successful mail is
> enclosed in the bug.
> The webrev is at:
> <http://cr.openjdk.java.net/%7Efyuan/8132660/webrev.00/>. It seems
> to be a big change but actually there are only some directories
More information about the core-libs-dev