RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases

Roger Riggs Roger.Riggs at Oracle.com
Tue Aug 11 04:38:30 UTC 2015

Hi Volker,

Looks fine.

Is there any way to test this?
It seems like it needs a special file system state that would not be 
readily available.

Thanks, Roger

On 8/10/15 9:57 AM, Volker Simonis wrote:
> Hi,
> can somebody please review this trivial fix?
> Thanks,
> Volker
> On Thu, Aug 6, 2015 at 5:27 PM, Volker Simonis <volker.simonis at gmail.com> wrote:
>> Hi,
>> can somebody please review the following small fix contributed by
>> matthias.baesken at sap.com:
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8133105/
>> https://bugs.openjdk.java.net/browse/JDK-8133105
>> Getting file attributes on Windows via GetFileAttributesExW() can fail
>> for some special system files. There is already code in
>> getFinalAttributes() which handles some of these special cases by
>> using FindFirstFileW().
>> However there are still cases which are not covered until now. For
>> example on PGP WDE (Whole Disk Encryption) – encrypted machines the
>> test java/io/File/WinSpecialFiles still fails for PGP files like
>> C:\pgpwde01. This small change fixes the issue.
>> Thank you and best regards,
>> Volker

More information about the core-libs-dev mailing list