RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases
volker.simonis at gmail.com
Tue Aug 11 08:50:46 UTC 2015
On Tue, Aug 11, 2015 at 6:38 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Hi Volker,
> Looks fine.
> Is there any way to test this?
> It seems like it needs a special file system state that would not be readily
Yes, it's not easy to reproduce the problem. I've tried to create a
file with the same attributes and access control lists like the
offending PGP files but couldn't succeed to reproduce the problem with
them. Even if I copy the offending file, the problem will not show on
the copy any more. So there must be something special about these
files but I couldn't find out what.
> Thanks, Roger
> On 8/10/15 9:57 AM, Volker Simonis wrote:
>> can somebody please review this trivial fix?
>> On Thu, Aug 6, 2015 at 5:27 PM, Volker Simonis <volker.simonis at gmail.com>
>>> can somebody please review the following small fix contributed by
>>> matthias.baesken at sap.com:
>>> Getting file attributes on Windows via GetFileAttributesExW() can fail
>>> for some special system files. There is already code in
>>> getFinalAttributes() which handles some of these special cases by
>>> using FindFirstFileW().
>>> However there are still cases which are not covered until now. For
>>> example on PGP WDE (Whole Disk Encryption) – encrypted machines the
>>> test java/io/File/WinSpecialFiles still fails for PGP files like
>>> C:\pgpwde01. This small change fixes the issue.
>>> Thank you and best regards,
More information about the core-libs-dev