RFR(m): 8067316: update RMI test library with better test.timeout.factor handling

Lance Andersen lance.andersen at oracle.com
Mon Jan 5 19:10:35 UTC 2015

Hi Stuart,

Looks OK to me :-)

On Jan 5, 2015, at 1:37 PM, Stuart Marks <stuart.marks at oracle.com> wrote:

> Hi all,
> Could I get a review for this? (Serves me right for posting this just before the holidays.)
> Turns out this is the root cause of some test failures.
> Thanks,
> s'marks
> P.S. Happy new year, everyone!
> On 12/23/14 5:24 PM, Stuart Marks wrote:
>> Hi all,
>> Please review this change, which adds handling of the test.timeout.factor
>> property to the RMI tests. These tests have a fair number of internal timeouts;
>> this change multiplies the timeout values by test.timeout.factor so that
>> timeouts will be less likely on slow systems, where a timeout factor has been
>> applied.
>> In order read this property, a bunch of the tests' security policy files needed
>> to be updated. This mainly impacted the policy files for the rmid activation
>> group JVMs. I took the opportunity to clean up these policy files as well so
>> that they're all fairly consistent among themselves.
>> The change updates a couple dozen policy files in a fairly stylized fashion. The
>> actual code changes are concentrated in the files ActivationLibrary.java,
>> JavaVM.java, RMID.java, and TestLibrary.java, which all appear at the end of the
>> webrev.
>> Webrev:
>>     http://cr.openjdk.java.net/~smarks/reviews/8067316/webrev.0/
>> Bug:
>>     https://bugs.openjdk.java.net/browse/JDK-8067316
>> Sandbox changeset:
>>     http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/419205f6b2d9
>> Thanks,
>> s'marks

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list