RFR: 8068732, Adding Initial RowSet tests
huizhe.wang at oracle.com
Sat Jan 10 01:12:20 UTC 2015
Looks good to me.
Are classes CachedRowSetTests and WebRowSetTests used? The Common* tests
seem to me all extends CommonCachedRowSetTests.
A minor point: would it make sense to add a rowSetType data provider
that includes listener(s)?
Some of the tests in CommonCachedRowSetTests are disabled, did they not
work? The unsetMatchColumn - SQLException tests that follow them imply
that the setMatchColumn method works.
On 1/9/2015 7:35 AM, Lance Andersen wrote:
> Hi all,
> Please find the webrev for adding an initial set of tests for RowSets. The webrev is at http://cr.openjdk.java.net/~lancea/8068732/webrev.00/
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
More information about the core-libs-dev