RFR (JAXP): 8054196: XPath: support any type

Lance Andersen lance.andersen at oracle.com
Fri Jan 16 21:29:50 UTC 2015

Hi Joe,

Overall it is OK, a few minor comments

-  Is there a reason that XPathExpressionImpl  is no longer public and XPathImpl is public?
- I think you can leverage {@inheritdoc} in your impl classes to avoid comment duplication possibly?
- please remember to make the copyright year 2015
- XPathTestBase, can the static block be moved to a @BeforeClass
- XPathNodes, should that have an @since 1.9?
- Given you are not including @param, etc for your test comments, you might want to consider /* */ vs /** */ style comments.  That is consider if you really want doc comments (really a style choice but some IDEs will issue a warning for missing tags


On Jan 16, 2015, at 2:51 PM, huizhe wang <huizhe.wang at oracle.com> wrote:

> Hi all,
> Could you review the change?
> Thanks,
> Joe
> On 12/18/2014 1:24 PM, huizhe wang wrote:
>> Hi,
>> This is to add support for any type and improvement with new features reflected in the new evaluateExpression methods, XPathEvaluationResult and XPathNodes.
>> https://bugs.openjdk.java.net/browse/JDK-8054196
>> http://cr.openjdk.java.net/~joehw/jdk9/8054196/webrev/
>> Thanks,
>> Joe

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list