RFR [XXS] 8130646: JCK test api/java_io/StringWriter/index_SWWrite5Test start failing after JDK-8077242

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue Jul 7 12:55:02 UTC 2015


With the fix for JDK-8077242 ((str) Optimize 
AbstractStringBuilder.append(CharSequence, int, int) for String 
argument) a change in behavior was introduced.

In the places, where sb.append(str.substring(from, to)) used to be 
called, in the case of wrong indices StringIndexOutOfBoundsException was 
Now, after I replaced the code to sb.append(str, from, to), in such 
cases IndexOutOfBoundsException is thrown.

The proposal is to make AbstractStringBuilder.append(CharSequence, int, 
int) throw more specific StringIndexOutOfBoundsException, which
1) will eliminate the regression,
2) will be more consistent with most other methods of 
AbstractStringBuilder, which throw StringIndexOutOfBoundsException.

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8130646
WEBREV: http://cr.openjdk.java.net/~igerasim/8130646/00/webrev/

Sincerely yours,

More information about the core-libs-dev mailing list