RFR [S] 8131034: Cleanup in j.u.regex.Pattern.quote()

Paul Sandoz paul.sandoz at oracle.com
Mon Jul 13 09:57:03 UTC 2015

On Jul 12, 2015, at 6:32 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:

> Hello!
> There's a minor issue in the current implementation of Pattern.quote() with possible numeric overflow when calculating initial capacity of StringBuilder.
> With the fix, some slight optimizations were done and a few typos were fixed.
> Would you please help review the fix?
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8131034
> WEBREV: http://cr.openjdk.java.net/~igerasim/8131034/00/webrev/

Looks ok.

-     * The pattern is converted to normalizedD form and then a pure group
+     * The pattern is converted to normalized form and then a pure group
      * is constructed to match canonical equivalences of the characters.

The "D" in "normalizedD form" may well be short hand for "canonical decomposition" (Normalizer.Form.NFD) as in "normalized canonical decomposition form".


> Sincerely yours,
> Ivan

More information about the core-libs-dev mailing list