RFR - 8027634: Support @argfiles for java command-line tool
mandy.chung at oracle.com
Wed Jul 15 14:51:52 UTC 2015
> On Jul 10, 2015, at 11:48 AM, Henry Jen <henry.jen at oracle.com> wrote:
> Please review proposed patch for JDK-8027634. This patch is to enable java support command line argument file like javac does. The implementation use the same syntax rule, which is implemented in CommandLine.java with java.io.StreamTokenizer.
> Some early comment is that we probably don’t need such complexity to support same syntax, also require to quote whole token is a little inconvenient. For example, must be -cp “c:\\foo bar\\lib;c:\\lib” instead of -cp c:\”foo bar”\lib;c:\lib.
> I am debating if such compatibility is necessary useful, after all, easy and intuitive is more important, and with simpler rule, the implementation will be cleaner as well.
I have a slight preference to maintain consistent syntax as javac @argfile support in terms of the quotation. A user could use the same path specified in -cp for both javac @argfile an java @argfile use.
I skimmed on the webrev and looks okay to me. I’ll leave it for Kumar to do detailed review. One minor comment:
Are you planning to remove the test within #ifdef DEBUG_ARGFILE block?
More information about the core-libs-dev