RFR(S): 8132704: [TESTBUG] jdk/internal/jimage/ExecutableTest.java incorrectly asserts all files to be executable
volker.simonis at gmail.com
Thu Jul 30 15:40:54 UTC 2015
On Thu, Jul 30, 2015 at 5:34 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Hi Volker,
> Possibly the real bug is that there is non-executable file in the bin
> There is a /conf directory which would probably be a better place for that.
Yes, I agree. But I thought you want a fast fix for the test failure :)
Moving that config file is probably a bigger effort.
Moreover the bin/ directory on Windows also contains .dll and .diz
files. However on Windows, all the files seem to be executable (at
least the test did succeed before). Nevertheless, checking only a
known subset of executables seems safer and "good enough".
What do you think?
> On 7/30/2015 11:28 AM, Volker Simonis wrote:
>> can somebody please review this test fix:
>> The initial test checked that all the files in the bin/ directory are
>> executable by everybody. Unfortunately this was too optimistic because
>> in the closed build the bin/ directory contains configuration files
>> which are not executable.
>> The new version of the test uses a predefined static list of
>> executables which are checked for the executable permissions if the
>> corresponding files exist.
>> Thank you and best regards,
More information about the core-libs-dev