<AWT Dev> Changes for JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository
alexander.kulyakhtin at oracle.com
Wed May 13 17:08:29 UTC 2015
Following the feedback from Jon Gibbons, we have changed our current plan to the following:
1) We are waiting till the new jtreg is promoted. The new jtreg allows for specifying in the repository's TEST.properties file one or more paths to search for libraries
2) After the jtreg is out we are adding both path to jdk/testlibrary and path to toplevel/test/lib/share library to the jdk and hotspot TEST.properties files
Under those testlibrary roots we are rearranging the directories to have the same jdk/test/lib structure (to provide for the jdk.test.lib package)
3) Same as with the current changes we are changing import package jdk.testlib.* to import package jdk.test.lib.* in the jdk and hotspot tests.
This way, if the jtreg does not find a required class from the jdk.test.lib in the jdk/testlibrary it will look for it in the toplevel/test/lib/share test library.
The same will be done for the hotspot tests.
----- Original Message -----
From: chris.hegarty at oracle.com
To: alexander.kulyakhtin at oracle.com
Cc: core-libs-dev at openjdk.java.net, awt-dev at openjdk.java.net, stefan.sarne at oracle.com, yekaterina.kantserova at oracle.com, hotspot-dev at openjdk.java.net, jdk9-dev at openjdk.java.net
Sent: Wednesday, May 13, 2015 7:48:06 PM GMT +03:00 Iraq
Subject: Re: <AWT Dev> Changes fro JDK-8075327: moving jdk testlibraty files duplicated in hotspot to the common test repository
> On 13 May 2015, at 16:46, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
> Hi Chris,
>> I suspect that these changes are best going directly into jdk9/dev, as
>> opposed to a a downstream forest.
> Yes, they are going directly to jdk9/dev, I forgot to add the group, adding now.
>> In may places '@library /lib/testlibrary ...' remains. Is this
>> redundant, in many tests? If so, it be removed.
> No, this is mostly not redundant, as the jdk/testlibrary comntains many files specific for jdk only. Only a relatively small number of files are duplicated between hotspot and jdk.
Right, but mostly is not all. For example test/com/sun/net/httpserver/Test1.java should no longer include @library /lib/testlibrary. It depends only on SimpleSSLContext which is being moved. It is easy to see this by looking at the imports.
Whatever script you have for updating these tests should also remove redundant values in the @library tag. I suspect there are a significant number of these ( a lot of tests just use one library class ).
Just on that, is it for a library class to indicate that it depends on a class from another library? I believe this is the case for some library utilities. How can a test know this. It needs to be a library class that indicates this dependency.I see nothing in the webrev for this ( or maybe I missed it ).
>> The changes are to the 'test' directory in the "top" repo? You are not
>> proposing to add a new repo, right?
> No, we are not proposing a new repo. The changes are in the 'top' repo.
>> test/lib/testlibrary/jdk/testlibrary/RandomFactory.java was updated
>> recently in jdk9/dev. The version in your webrev is a little out of date.
> We are going to upmerge the changes then
>> Is there any special update needed to jtreg to support this?
> For thse changes no jtreg update is required.
> However, there are plans for the jtreg to prohibit referencing any @libraries above the repo root unless such libraries are directly specified in TEST.properties
> If jtreg thus prohibits our using /../../test/lib (because it's above the root) we will have to additionally make a change to jdk and hotspot TEST.properties
> Best regards,
More information about the core-libs-dev