RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo
dmitry.samersoff at oracle.com
Wed May 20 06:51:23 UTC 2015
> However I have trouble for
> Finalizer.printFinalizationQueue method that doesn’t belong there.
> What are the other alternatives you have explored?
Other alternatives could be to do all hashing/sorting/printing on native
layer i.e. implement printFinalizationQueue inside VM.
Both options has pros and cons - Java based solution requires less JNI
calls and better readable but takes more memory.
It might be better to return an array of Map.Entry<String, int>
objects to VM rather than one huge string.
On 2015-05-20 05:54, Mandy Chung wrote:
>> On May 18, 2015, at 5:17 AM, Dmitry Samersoff
>> <dmitry.samersoff at oracle.com <mailto:dmitry.samersoff at oracle.com>> wrote:
>> Please review updated version of the fix:
>> Most important part of the fix provided by Peter Levart, so all
>> credentials belongs to him.
> My apology for being late to the review. The subject line doesn’t catch
> my attention early enough :)
> I have to do further detail review tomorrow or so to follow the
> discussion and closely inspect the reference implementation. Just to
> give you a quick comment. I’m okay to add ReferenceQueue.forEach method
> at the first glance. However I have trouble for
> Finalizer.printFinalizationQueue method that doesn’t belong there. What
> are the other alternatives you have explored?
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the core-libs-dev