JDK 9 RFR of JDK-8138823: Correct bug in port of fdlibm hypot to Java

Brian Burkhalter brian.burkhalter at oracle.com
Tue Oct 6 18:26:47 UTC 2015

Hi Joe,

On Oct 2, 2015, at 7:26 PM, joe darcy <joe.darcy at oracle.com> wrote:

> Please review the changes for
>    JDK-8138823: Correct bug in port of fdlibm hypot to Java
>    http://cr.openjdk.java.net/~darcy/8138823.0/
> The change to java/lang/FdLibm.java is to correct a problem analogous to one recently corrected in the port of the pow method.

This looks good.

> The testing includes a few improvements, including the addition of FdlibmTranslit.java to host transliteration ports of the fdlibm methods.

This is a good idea.

Do you think that at lines 60-64 of HypotTests it would be worth printing separate failure counts for standard versus transliteration failures?

> That is, Java ports of the code that are as close to the C versions as possible while still being readable. For the code used for java.lang.StrictMath, it is desirable for the code to be faster and to be closer to idiomatic Java.

Something like createRandomDouble() from StrictMath/Tests.java would not be a bad addition to j.u.Random, e.g.,

public double nextFullRangeDouble() {}

although this is somewhat covered by Random.doubles(double,double) {}.

Overall: +1.



More information about the core-libs-dev mailing list