JDK 9 RFR of JDK-8136799 Port fdlibm cbrt to Java
Joseph D. Darcy
joe.darcy at oracle.com
Wed Oct 14 23:17:54 UTC 2015
On 10/14/2015 1:34 PM, Brian Burkhalter wrote:
> Hi Joe,
> On Oct 12, 2015, at 8:53 AM, joe darcy <joe.darcy at oracle.com
> <mailto:joe.darcy at oracle.com>> wrote:
>> Please review the next step of porting fdlibm to Java, the cbrt method:
>> JDK-8136799 Port fdlibm cbrt to Java
> * I assume that the diffs other than those of the Cbrt class itself
> are artifacts of webrev creation and no other (significant) changes
> are present elsewhere in the patch.
> * Based on code inspection, the cbrt port itself appears to be accurate.
> * line 487: “hypot” -> “cbrt”
> * line 504: probably need to insert a blank line after this line and
> possibly remove the blank line at 507.
Corrected and pushed; thanks,
More information about the core-libs-dev