RFR (M) 8140802 - Clean up and refactor of class loading code for CDS

Jiangli Zhou jiangli.zhou at oracle.com
Fri Oct 30 20:23:53 UTC 2015

Hi Ioi,

The change looks pretty clean. The new src/share/vm/classfile/systemDictionary_ext.hpp and src/share/vm/classfile/vmSymbols_ext.hpp do not have copyright header. Please add the copyright headers. Please also fix the copyright year for the modified files prior to pushing.

In src/share/vm/classfile/sharedPathsMiscInfo.hpp, is the new “#include “classify/classLoader.hpp” necessary?

I agree with the comments from Colleen and Karen regarding the usage of new_permanent_symbol() and TempNewSymbol in classLoaderExt.cpp. It doesn’t seem to be consistent.


> On Oct 30, 2015, at 10:00 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> Please review the following fix:
> http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/
> Bug: Clean up and refactor of class loading code for CDS
>    https://bugs.openjdk.java.net/browse/JDK-8140802
> Summary of fix:
>    We need to clean up and refactor the class loading code in order
>    to support CDS in JDK9
>    [1] Remove code that has been made obsolete by the module changes
>        (such as supporting code used for meta-index file)
>    [2] Add new whitebox API to be used by CDS-related tests.
>    [3] Refactor the parsing of classlist files for future enhancements.
>    [4] Add new APIs in the class loading code to support Oracle CDS enhancements.
> Tests:
>    JPRT
>    RBT - with same set of tests as hs-rt nightly
> Thanks
> - Ioi

More information about the core-libs-dev mailing list