RFR <8064470 > JNI exception pending in jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c
chris.hegarty at oracle.com
Tue Sep 1 09:12:53 UTC 2015
On 1 Sep 2015, at 09:38, Vyom Tewari <vyom.tewari at oracle.com> wrote:
> Hi everyone,
> Can you please review my changes for below bug.
> JDK-8064470 : JNI exception pending in jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c
The changes look ok to me, and consistent with the Windows variant. Note that the final CHECK_NULL is not strictly necessary, but we seem to have adopted this style to avoid potential future mistakes if additional code is added.
> This change ensure that we immediately return if an exception has been raised (result == NULL) by GetMethodId() or proceed to the next
> line if there is no JNI pending exception.
> if result is NULL, there is a pending exception, and we return. if result is not NULL, there is no pending exception, and we proceed to the next line...
More information about the core-libs-dev