RFR: 8136583: Core libraries should use blessed modifier order

Paul Sandoz paul.sandoz at oracle.com
Wed Sep 16 10:57:56 UTC 2015

On 16 Sep 2015, at 02:42, Martin Buchholz <martinrb at google.com> wrote:

> Hi, Chris and Paul,
> I'd like you to do a very boring code review.
> This change is entirely machine generated. (the script is more interesting)
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/blessed-modifier-order/blessed-modifier-order.patch
> https://bugs.openjdk.java.net/browse/JDK-8136583

AFAICT the script you used to produce the changes looks fine (a perl script embedded into a bash script :-) ).

After a certain point i cannot review the actual changes, my eye-balls give up :-) so i have to trust that it all compiles and tests run. Did you apply this patch internally and test?


More information about the core-libs-dev mailing list