JDK 9 RFR of JDK-7130085 Port fdlibm hypot to Java
brian.burkhalter at oracle.com
Tue Sep 22 23:20:12 UTC 2015
Overall this looks good. I only have a couple of minor observations related to internal documentation.
Lines 158-166: The verbiage in the note might benefit from a little reworking.
Line 46: “Commutative” is misspelled.
On Sep 21, 2015, at 6:22 PM, Joseph D. Darcy <Joe.Darcy at Oracle.Com> wrote:
> Please review the next portion of the port of fdlibm to Java:
> JDK-7130085 Port fdlibm hypot to Java
> As before with pow, this isn't necessarily the end state of the code we'd like to stop at, but it should be sufficiently idiomatic Java for an initial port.
> To make comparison against the original C algorithm easier, I listed the C version of hypot as the base file to compare FdLibm.java against.
More information about the core-libs-dev