RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization
michael.haupt at oracle.com
Fri Sep 25 13:37:03 UTC 2015
thanks for this changeset. Note I'm not a Reviewer (with a capital R); please read this review in lower-case. ;-)
One question about MethodType: would you mind doing something about the naming of the newly introduced fromDescriptor() method? Its name does not suggest in any way that it chooses the class loader differently. The name is subtly different from that of fromDescriptorString(), and the signature is identical - it's probably really easy to confuse the two when working at the core libs level. Unfortunately, the only proposal for a name I can make, fromDescriptorStringBootCL(), is clunky. Maybe that's acceptable for a low-level method only visible at package level.
> Am 25.09.2015 um 08:46 schrieb Peter Levart <peter.levart at gmail.com>:
> I have run the tests in java.lang.invoke and only have a problem with 1 test which seems to be related to the test or jtreg itself and happens also without my patch applied:
> #Test Results (version 2)
> #Tue Sep 22 09:48:38 CEST 2015
> test result: Error. Parse Exception: `@library' must appear before first `@run'
Yes. The test is also marked as ignored until another issue is fixed, so that can be ignored.
Other than the above remark/suggestion, this looks fine. I'll defer to an upper-case Reviewer, though.
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
<http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
More information about the core-libs-dev