RFR: 8161379: Force inline methods calling Reflection.getCallerClass
aleksey.shipilev at gmail.com
Fri Aug 5 19:56:55 UTC 2016
This looks good to me, Claes.
I wouldn't mind to have a comment at @ForceInline line mentioning this
is for Reflection.getCallerClass() optimization. But, it might be
recoverable from the source control anyway.
On 08/05/2016 10:37 PM, Claes Redestad wrote:
> On 07/19/2016 08:16 AM, Claes Redestad wrote:
>> most @CallerSensitive methodscall Reflection.getCallerClass(), which
>> turn out to have problematic performance characteristics when it fails
>> to inline.
>> Making @CallerSensitive imply @ForceInline actually works rather well
>> across benchmarks, but didn't meet with approval from hotspot-compiler
>> because it's a hack (unlike @ForceInline /s).
>> Instead, here is a patch to explicitly @ForceInline those methods where
>> it can plausibly be helping with performance:
>> Webrev: http://cr.openjdk.java.net/~redestad/8161379/jdk.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8161379
More information about the core-libs-dev