RFR: 8163476: java/lang/StackWalker/VerifyStackTrace.java fails after JDK-8163369

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue Aug 9 12:41:31 UTC 2016

Hi Claes!

Not a thorough review, but a minor comment.

209                     .replaceAll("DMH.invoke", "DMH/xxxxxxxx.invoke")

The dot in the regexp needs to be escaped here.

With kind regards,

On 09.08.2016 15:26, Claes Redestad wrote:
> <resending due to missing RFR in subject>
> On 2016-08-09 13:48, Claes Redestad wrote:
>> Hi,
>> change to enable DMH pre-generation caused a subtle change in the 
>> stacktrace, which caused this test to fail.
>> Please review this patch which reverts the stackframe to look like 
>> before for non-pregenerated DMHs, while also updating the test to 
>> accept pregenerated DMHs.
>> To verify this works I added invokeVirtual_LL_V (used in the test) to 
>> the list of pre-generated DMHs in GenerateJLIClassesPlugin and 
>> verified that the test pass both on a jlinked image and an exploded 
>> image.
>> Webrev: http://cr.openjdk.java.net/~redestad/8163476/webrev.01
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8163476
>> Thanks!
>> /Claes

More information about the core-libs-dev mailing list