RFR: 6543126: Level.known can leak memory
daniel.fuchs at oracle.com
Thu Aug 11 09:29:10 UTC 2016
On 10/08/16 17:21, Mandy Chung wrote:
>> On Jul 29, 2016, at 4:54 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>> > http://cr.openjdk.java.net/~dfuchs/webrev_6543126/webrev.01/
> This looks pretty good.
> Since KnownLevel is now a Reference, I suggest to change KnownLevel::findByName, findByValue and findByLocalizedLevelName to return Optional<Level> instead such that the parse method implementaiton could be simplified.
We need to return KnownLevel because sometimes we need the
level object and sometimes the mirror.
I tried returning Optional<KnownLevel> but it does not make the
code any simpler.
More information about the core-libs-dev