RFR: 8164982 Fix legal notices in java/lang, java/net, java/util tests.

Iris Clark iris.clark at oracle.com
Tue Aug 30 03:19:18 UTC 2016

Hi, Shura.

> Webrev: http://cr.openjdk.java.net/~shurailine/8164982/webrev.00/

The problem noted in [3] is not present in the latest webrev.

The changes look fine with me.


-----Original Message-----
From: Alexandre (Shura) Iline 
Sent: Monday, August 29, 2016 3:16 PM
To: core-libs-dev
Subject: RFR: 8164982 Fix legal notices in java/lang, java/net, java/util tests.


Webrev: http://cr.openjdk.java.net/~shurailine/8164982/webrev.00/

This was previously reviewed as part of [1]. The script for generating these changes is in process of being fixed. Meanwhile, I suggest to start integrating portions of the work.

The tests included in this fix have already been reviewed by Joe [2]. I have also re-reviewed the changes to make sure the problem noted by Iris [3] is not present in these tests. I assume this change can be integrated, then.

[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004643.html
[2] http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004645.html
[3] http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-August/004651.html

> On Aug 15, 2016, at 5:14 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
> The lang, net, and util changes looks fine; cheers,
> -Joe
> On 8/15/2016 11:39 AM, Alexandre (Shura) Iline wrote:
>> Hi,
>> Please review this bulk update of JDK test sources which is fixing legal notices formatting and content.
>> http://cr.openjdk.java.net/~shurailine/8164052/webrev_00/
>> I am sending this to the jdk9-dev at openjdk.java.net hoping that would be enough. Otherwise I would send the request to multiple aliases which have tests in idk repository.
>> Shura

More information about the core-libs-dev mailing list