RFR: 8162431: CatalogUriResolver with circular/self referencing catalog file is not throwing CatalogException as expected.

Lance Andersen lance.andersen at oracle.com
Wed Aug 31 20:14:51 UTC 2016

Looks OK Joe

> On Aug 29, 2016, at 3:18 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> Hi,
> Please review a patch that fixes an issue where circular references were not caught if catalogs are pre-loaded. Note that to trigger the issue (circular references), the Catalog must be instructed to load additional catalogs. This can be done by either setting DEFER to false, or providing an uri that does not have a match in the current catalog (thus causes the CatalogResolver to load alternative catalogs).  When the uri is empty as in the original JCK test, the CatalogResolver will skip the resolution and therefore no additional catalogs will be loaded. In the unit test, the test (copied from the JCK test) is fixed by adding a bogus uri 'anyuri'. The JCK test will need a similar fix.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8162431
> webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8162431/webrev/
> Thanks,
> Joe

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list