RFR: 8072379: Implement jdk.Version and jdk.OracleVersion
mandy.chung at oracle.com
Tue Jan 12 22:25:53 UTC 2016
> On Jan 11, 2016, at 1:44 PM, Iris Clark <iris.clark at oracle.com> wrote:
> Hi, Joe, Roger, Alan, Magnus, and Mandy.
> At the end of December (shortly before the Christmas/Winter
> break and my vacation), I provided responses to your messages
> and an updated webrev:
It’s good to see that jdk.OracleVersion has been removed and use jdk.Version to obtain the fourth element of the version number.
This patch looks good in general. Minor comment:
273 current = parse(System.getProperty("java.version"));
System.getProperty will do a permission check and it needs to be called within a doPrivileged block.
154 * @see <a href="http://openjdk.java.net/jeps/223">JEP 223: New Version-String Scheme</a>
Does the javadoc have the essential information from this JEP? Wonder if this @see is necessary.
Alan already comment on the “jdk” package that needs to find the proper module to export it (that’s a future RFE) and modules.xml should be updated.
More information about the core-libs-dev