RFR: 8072379: Implement jdk.Version and jdk.OracleVersion

Dmitry Samersoff dmitry.samersoff at oracle.com
Thu Jan 14 08:58:14 UTC 2016


Did you consider to split version string into array of groups first
(using String.split()), then validate each group separately?

It may make the code better readable and more resilient to possible
future changes.


On 2015-11-25 04:54, Iris Clark wrote:
> Hi.
> Please review the new classes jdk.Version and jdk.OracleVersion.  These are
> simple Java APIs to parse, validate, and compare version numbers.
>   Bug
>     8072379: Implement jdk.Version and jdk.OracleVersion
>     https://bugs.openjdk.java.net/browse/JDK-8072379
>   Webrev
>     http://cr.openjdk.java.net/~iris/verona/8072379/webrev.1/
>   JavaDoc
>     http://cr.openjdk.java.net/~iris/verona/8072379/doc.1/jdk/Version.html
>     http://cr.openjdk.java.net/~iris/verona/8072379/doc.1/jdk/OracleVersion.html
> The .java files are predominantly javadoc. The code is relatively
> straight-forward.
> jdk.Version is the representation of the JDK version string as described in
> JEP 223 ([0], 8061493).  The javadoc is largely taken from the description
> section in the JEP.  The API is described in the "API" section.
> jdk.OracleVersion extends jdk.Version and is the representation of the Oracle
> JDK version string.  Its only purpose is to interpret the fourth element of
> the version number as a patch release.
> There are some minor discrepancies between the implementation and the JEP.
> The JEP will need to be updated.  The most notable is the name of the package
> ("jdk" vs. the original "jdk.util").  The rename was recommended by Mark.
> Thanks,
> iris
> [0] http://openjdk.java.net/jeps/223

Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

More information about the core-libs-dev mailing list