RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection
mark.sheppard at oracle.com
Thu Jan 21 17:45:28 UTC 2016
i can revert the isClosed(), I put them in to make the access consistent
On 20/01/2016 18:17, Seán Coffey wrote:
> Hi Mark,
> line 125, could you use a 2 arg method call to dprint. It'll print the
> stacktrace instead :
> dprint(".close: selector.close: " + t); --> dprint(".close:
> selector.close", t);
> The "while (!isClosed()) " change introduces a new hot lock on closed
> variable. Hopefully, it won't impact performance too much.
> Looks good to me otherwise.
> On 20/01/16 16:16, Mark Sheppard wrote:
>> an update has been made to the webrev
>> an anomaly was found in the select loop of the SelectorImpl.run() method
>> some defensive programming, for selector null references, have been
>> added, also.
>> On 08/01/2016 17:49, Mark Sheppard wrote:
>>> please oblige and review the following changes
>>> which addresses the issue
>>> the changes ensure that an Acceptor and its associated
>>> are closed.
More information about the core-libs-dev