RFR [9] 8148117: Move sun.misc.Cleaner to jdk.internal.ref

Roger Riggs Roger.Riggs at Oracle.com
Tue Jan 26 14:59:39 UTC 2016

Hi Chris,

Looks fine.

Perhaps update the copyrights.

Upgrading the shell based test to java based would be good sometime too.

Also, there is a more recent version of webrev [1] that provides 
convenient next and previous links.

Thanks, Roger

[1] http://hg.openjdk.java.net/code-tools/webrev/raw-file/tip/webrev.ksh

On 1/26/2016 8:55 AM, Chris Hegarty wrote:
> It is wonderful to see the various ideas on this thread about the longer
> term solution to the prompt releasing of direct buffer native memory. I
> do not want to obstruct that ( it is very informative ), but I’d like to warp up
> the review on the actual moving of Cleaner. To that end, I’ve update the
> webrev as per Alan’s comments and suggestion ( to extend Runnable ).
> http://cr.openjdk.java.net/~chegar/8148117/
> -Chris.
> On 23 Jan 2016, at 16:36, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On 23/01/2016 16:16, Chris Hegarty wrote:
>>> :
>>> Webrev:
>>>    http://cr.openjdk.java.net/~chegar/8148117/
>> This has to move to your patch looks okay. You might need to update the TEST.groups to ensure that the existOnThrow tests will be run by jdk_core.
>> -Alan.

More information about the core-libs-dev mailing list