RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

Steve Drach steve.drach at oracle.com
Thu Jan 28 17:51:52 UTC 2016

>>> Shouldn't you also include the FileOuputStream in try-with-resources?
>> It is. Do you need to refresh your browers?
> If you read the code quickly, I missed it too, maybe it would be better to put the opening brace on a separate line, i.e.:
> try (ZipFile in = new ZipFile("multi-release.jar");
>     FileOutputStream os = new FileOutputStream("signed-multi-release.jar"))
> {
>    js.sign(in, os);
> }

Done.  See http://cr.openjdk.java.net/~sdrach/8147607/changeset <http://cr.openjdk.java.net/~sdrach/8147607/changeset>

More information about the core-libs-dev mailing list