RFR: 8148626: URI.toURL needs to use protocol Handler to parse file URIs

Claes Redestad claes.redestad at oracle.com
Sun Jan 31 00:58:35 UTC 2016


On 2016-01-30 19:35, joe darcy wrote:
> Hello,
> The change looks okay in that the new code is limited to the jrt 
> protocol. I assume the failing test
>     java/net/URL/B5086147.java
> passes again with this change.

I had to go through some hoops to find out how to ensure this test 
actually gets picked up by the remote-testing incantation I've been 
using so far, but have verified the test has been run and passes on the 
affected platforms.

> If a fix for this issue is not pushed soon, I want to have the failing 
> test problem listed 
> (http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-January/038459.html).

I'm ready push this, but might be good to get a second opinion from 
net-dev to ensure they aren't caught unaware of this follow-up fix.


> Thanks,
> -Joe
> On 1/30/2016 6:30 AM, Claes Redestad wrote:
>> Hi,
>> it turns out trying to optimize URI to URL conversion for file URLs 
>> don't work out very well due to special treatment of backward slashes.
>> Instead of trying to deal with such file URLs, this patch partially 
>> backs out 8147462 and only leave the optimization in place for the 
>> jrt protocol. This still helps
>> reducing footprint in jigsaw while keeping things performance neutral 
>> for other kinds of URLs.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8148626
>> Webrev: http://cr.openjdk.java.net/~redestad/8148626/webrev.01/
>> /Claes

More information about the core-libs-dev mailing list