RFR: 8157524 Revert JarFile methods "entries" and "stream" to Java 8 behavior

Paul Sandoz paul.sandoz at oracle.com
Mon Jul 18 08:23:23 UTC 2016

> On 15 Jul 2016, at 23:17, Steve Drach <steve.drach at oracle.com> wrote:
> Hi,
> Please review this change to JarFile that reverts JarFile::stream and JarFile::entries to JDK 8 behavior.  The code is identical to that in JDK 8 except line 504 in JarEntryIterator that now uses a different constructor to create a JarFileEntry.  I also added some implementation notes explaining how to create a versionedStream and a versionedEntries method.
> issue: https://bugs.openjdk.java.net/browse/JDK-8157524 <https://bugs.openjdk.java.net/browse/JDK-8157524>
> webrev: http://cr.openjdk.java.net/~sdrach/8157524/webrev/index.html <http://cr.openjdk.java.net/~sdrach/8157524/webrev/index.html>

You should use an @apiNote, as this is presenting some interesting information on how to use this method and not some particular characteristics of the implementation.

I would be inclined to drop the note for Enumeration and add a @see tag referencing the Stream returned method.


More information about the core-libs-dev mailing list