RFR JDK-8166261: Scanner.nextInt(int) (and similar methods) throws PatternSyntaxException
naoto.sato at oracle.com
Wed Oct 5 17:25:19 UTC 2016
Looks good to me.
The test case could use IntStream.rangeClosed(Character.MIN_RADIX,
Character.MAX_RADIX) for the good radixes, instead of hard coding ints.
On 10/5/16 8:53 AM, Xueming Shen wrote:
> Please help review
> issue: https://bugs.openjdk.java.net/browse/JDK-8166261
> webre: http://cr.openjdk.java.net/~sherman/8166261/webrev
> The radix sanity check are missing from
> The only method we are doing now is useRadix(). The proposed change here
> is to
> add the check into all above methods that take a radix.
> Arguably it's an incompatible api change, but I don't expect it really
> breaks anyone's
> code. Need go through ccc if approved.
More information about the core-libs-dev