RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable
mandy.chung at oracle.com
Tue Oct 11 15:47:01 UTC 2016
> On Oct 10, 2016, at 11:03 PM, Peter Levart <peter.levart at gmail.com> wrote:
> Hi Brent,
> On 10/11/2016 12:44 AM, Brent Christian wrote:
>> On 10/10/16 2:30 PM, Mandy Chung wrote:
>>> The patch looks fine. It would be good to add @see
>>> #registerAsParallelCapable in this new method. Also the first
>>> “parallel capable” occurrance in the class spec and the
>>> registerAsParallelCapable method spec to @linkplain
>> Thanks for having a look, and for the suggestions. I also added an @see #isParallelCapable in registerAsParallelCapable().
>> Webrev updated in place:
> It would be marginally more efficient to check for parallelLockMap != null instead of looking up the CL implementation class in the WeakHashMap within a synchronized block, but I guess the performance of this method is not very important, is it?
parallelLockMap != null is another way to check that. Sinc this method isn’t performance critical, calling ParallelLoaders::isRegistered is easier to understand.
More information about the core-libs-dev