RFR 8168127: FilePermissionCollection merges incorrectly

Roger Riggs Roger.Riggs at Oracle.com
Tue Oct 25 14:12:02 UTC 2016

Hi Max,

It might be worth a comment (Lines 258 and 270) that the names are 
generated to be different than the original.
Otherwise, looks fine.


On 10/19/2016 10:47 PM, Wang Weijun wrote:
> Please review the code change at
>     http://cr.openjdk.java.net/~weijun/8168127/webrev.00/
> Two changes:
> 1. npath2 is considered in equals and hashCode of FilePermission, so 2 objects with different npath2 can be added to a map and different entries.
> 2. special name for newPermUsingAltPath and newPermPlusAltPath results, so FilePermissionCollection::add will not merge one with the original.
> Thanks
> Max

More information about the core-libs-dev mailing list