8152515: (logging) LogManager.resetLogger should ignore LinkageError
daniel.fuchs at oracle.com
Fri Oct 28 16:15:27 UTC 2016
On 28/10/16 17:00, Jonathan Bluett-Duncan wrote:
> I've an awful suspicion that the `catch (LinkageError e)` block is
> unreachable, as the `catch (Exception e)` block would run first, being
> located above the other block in the source code.
> Is my suspicion correct?
Not really. As its name indicate, LinkageError is an Error, not a
subclass of Exception.
> Kind regards,
> On 28 October 2016 at 16:36, Jason Mehrens <jason_mehrens at hotmail.com
> <mailto:jason_mehrens at hotmail.com>> wrote:
> Looks good to me.
> Thanks for fixing this!
> From: Daniel Fuchs <daniel.fuchs at oracle.com
> <mailto:daniel.fuchs at oracle.com>>
> Sent: Friday, October 28, 2016 6:51 AM
> To: core-libs-dev
> Cc: Jason Mehrens
> Subject: RFR: 8152515: (logging) LogManager.resetLogger should
> ignore LinkageError
> Please find below a trivial patch for:
> 8152515: (logging) LogManager.resetLogger should ignore LinkageError
> The issue might occur at shutdown, when a handler that makes uses
> of some APIs provided by an OSGI bundle which was already closed
> by the shutdown process is in turn closed by the LogManager.Cleaner
> thread. In that case some subclasses of LinkageError may be thrown,
> interrupting the reset process and preventing other handlers from
> being closed properly.
> The patch proposes to trivially ignore LinkageError at shutdown while
> the LogManager.Cleaner thread is running.
> best regards,
> -- daniel
More information about the core-libs-dev