RFR: 8168923: Use unsigned random long in a temp directory name
brian.burkhalter at oracle.com
Mon Oct 31 16:00:41 UTC 2016
Aside from the inevitable copyright year update this looks fine to me. What effect does it have on the regression test run?
On Oct 29, 2016, at 8:43 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> Hello everyone!
> When File.createTempFile() is called, a random long value is generated, which is then made positive with Math.abs() and then used as a part of the directory name.
> Instead of using Math.abs() and Long.toString(), it would be better to use Long.toUnsignedString():
> 1) no need to deal with the corner case of Long.MIN_VALUE,
> 2) increase the space of random values by the factor of 2.
> Would you please help review the fix?
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8168923
> WEBREV: http://cr.openjdk.java.net/~igerasim/8168923/00/webrev/
> With kind regards,
More information about the core-libs-dev