RFR: JDK-8161230 ClassLoader: add resource methods returning java.util.stream.Stream

Andrej Golovnin andrej.golovnin at gmail.com
Fri Sep 2 06:09:14 UTC 2016

Hi Patrick,


The constant RESOURCE_CHARACTERISTICS in the line 215 should be
defined near the #streamOf()-method. The distance between the line
1412 where the #streamOf()-method is defined and the line 215 is just
too huge.

Your patch seems to modify the JavaDocs of the methods #getParent(),
#getPlatformClassLoader(), #getSystemClassLoader(). But I don see how
it is related to the issue you try to solve.


The indentation is broken. You use tabs. But in JDK you must use
spaces, see http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-indentation

Best regards,
Andrej Golovnin

On Thu, Sep 1, 2016 at 10:06 PM, Patrick Reinhart <patrick at reini.net> wrote:
> Hi Alan,
> Hi Paul,
> Here is the first revision of the implementation based on our earlier conversation.
> http://cr.openjdk.java.net/~reinhapa/reviews/8161230/webrev.00 <http://cr.openjdk.java.net/~reinhapa/reviews/8161230/webrev.00>
> - Patrick

More information about the core-libs-dev mailing list